Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dconv no longer uses global instances of StringToDoubleConverter and #469

Merged

Conversation

das-intensity
Copy link
Contributor

…DoubleToStringConverter

Fixes #420
Closes #420 (nice)

Changes proposed in this pull request:

  • Stop using global instances of StringToDoubleConverter and DoubleToStringConverter across threads

Based on my python knowledge, there should be no reason that this change is necessary, however

  1. It fixes a (hard to debug/reproduce) issue that multiple users have had
  2. It doesn't cause any harm, and I would argue is more correct regardless

Thanks to @yechiel-optimalq for his detailed issue report, and @klimermana for helping debug and develop this fix

If this is accepted, please also backport to 3.2 as some people are stuck using python3.5 (despite it being EOL).

@hugovk hugovk added the changelog: Fixed For any bug fixes label Aug 6, 2021
@das-intensity
Copy link
Contributor Author

@hugovk do we need anything else for this PR?

@hugovk
Copy link
Member

hugovk commented Aug 13, 2021

Let's get this merged, thanks!

@hugovk hugovk merged commit 8f5ad61 into ultrajson:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python multi-threaded app - Segmentation fault
2 participants