New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vendored double-conversion to 3.2.1 #570
Conversation
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 6 6
Lines 1905 1905
=======================================
Hits 1743 1743
Misses 162 162 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
About this - It needs webassembly tests adding, I can do this once a PR to pytest-pyodide (pyodide/pytest-pyodide#59 )is added to make it possibly to skip non-pyodide tests |
What would make a test non-pyodide? Any reason we can't just add a few @pytest.mark.skipif(platform.machine().startswith("wasm"), "Not supported on pyodide") statements instead (assuming there's not a better way to detect if running on |
@bwoodsend pyodide uses a custom pytest plugin which assumes you're writing tests to run things in pyodide. It means you can do things like spin up servers for pyodide code in a browser to talk to. But right now there's no way to just run normal pytest tests on pyodide. It would need to spin up a browser+pyodide for each test or for each module of tests or something, and then run the tests in there automatically. At the moment if you want pyodide tests, you have to write a custom test_pyodide.py for your project which wraps the project tests and calls them in pyodide. |
Okay, fair enough. I'll merge this now since it's only updating double-conversion (which we really ought to be more proactive in keeping up to date anyway) and keep any mention of supporting WASM out of the changelog until the tests go in. |
@bwoodsend Any chance of a release to pypi to get this version onto pypi and save me build pain... |
Release button has been pressed. |
Ultrajson doesn't build on webassembly (e.g. pyodide) because the version of double-conversion used is too old. This updates it to a newer version which supports webassembly.