Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer Update takes minutes to complete #190

Closed
AmazingTurtle opened this issue Oct 19, 2019 · 3 comments
Closed

Renderer Update takes minutes to complete #190

AmazingTurtle opened this issue Oct 19, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@AmazingTurtle
Copy link

#include "stdafx.h"
#include <Ultralight/Ultralight.h>
#include <AppCore/AppCore.h>
#include "UltralightUI.hpp"

#pragma comment(lib, "Ultralight.lib")
#pragma comment(lib, "UltralightCore.lib")
#pragma comment(lib, "WebCore.lib")

using namespace ultralight;

UltralightUI::UltralightUI() {
	this->width = 1024;
	this->height = 768;
	this->renderer_ = Renderer::Create();
	this->view_ = renderer_->CreateView(this->width, this->height, false);
	this->view_->LoadURL("http://localhost:3000/");
}
void UltralightUI::Update() {
	MessageBoxA(NULL, "Update started", "ULUI", 0);
	this->renderer_->Update();
	MessageBoxA(NULL, "Update ended", "ULUI", 0);
}

...

Update is called from the main thread loop. It takes minutes to complete (each time it takes a bit longer). Why is that?
On localhost:3000 I'm serving a nextjs dev page.

@adamjs
Copy link
Member

adamjs commented Oct 19, 2019

Hmm, can you give more info regarding your "nextjs dev page" so I can reproduce on my side and debug?

@adamjs
Copy link
Member

adamjs commented Oct 19, 2019

From slack:

Turtle 1:32 PM
https://github.com/iaincollins/nextjs-starter
Platform: Windows, also seems to have an access violation in UltralightCore.

I'll trace and debug.

@adamjs adamjs self-assigned this Oct 19, 2019
@adamjs adamjs added the bug Something isn't working label Oct 19, 2019
@adamjs
Copy link
Member

adamjs commented Jul 14, 2020

Retested this today and seems to be fixed in latest trunk.

@adamjs adamjs closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants