Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what's the original NMS method in yolov3? #1069

Closed
Gaondong opened this issue Apr 19, 2020 · 8 comments
Closed

what's the original NMS method in yolov3? #1069

Gaondong opened this issue Apr 19, 2020 · 8 comments
Labels

Comments

@Gaondong
Copy link

I saw that you have made many efforts on NMS.
What is the original yolov3 paper nms speed? Did it in this project? I want to compare them.
I am failed install torchvision, So I test fast-NMS on jetson tx2, It cost 10ms.
What's difference in torchvision method and original yolov3 nms method.

@glenn-jocher
Copy link
Member

@Gaondong torchvision nms and yolov3 nms are the same.

@Gaondong
Copy link
Author

Gaondong commented Apr 19, 2020

@Gaondong torchvision nms and yolov3 nms are the same.
@glenn-jocher
It sames that the torchvision method is faster and more accuracy than Fast-nms.
But in Fast-nms paper, It sames original nms methods cost more time.

@glenn-jocher
Copy link
Member

See #679

Fast NMS is slower than torchvision.

@Gaondong
Copy link
Author

See #679

Fast NMS is slower than torchvision.
@glenn-jocher
Yes I saw your torchvision is best performance,
I have also used your previous version, nms is relatively slow. Is it just because the calculation method of torchvision is faster than the previous calculation of torch cuda?
Why is the torchvision version so much faster than the original yolov3 paper implementation?

@glenn-jocher
Copy link
Member

Torchvision has cpu and CUDA optimized versions, I’m assuming they programmed them for optimal runtime on both sets of hardware.

@Gaondong
Copy link
Author

Torchvision has cpu and CUDA optimized versions, I’m assuming they programmed them for optimal runtime on both sets of hardware.

Thanks for your reply.
In AleayAB's darknet project, there is a hyper parameter counter_per_class,
https://github.com/AlexeyAB/darknet/issues/4792
Could it in this project?

@glenn-jocher
Copy link
Member

@Gaondong we don't have this, but if you'd like to submit a PR we can review it!

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove Stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants