-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
line 9~20 in train.py may not work #40
Comments
Oh, thats an interesting comment @violet17. Yes at first this did not work, which is why I added line 23 before importing test.py, to prevent the first namespace from impacting the second. Lines 22 to 24 in 35e445c
I did not think about your solution, but yes this could work also. Which one is better from a 'best-practices' standpoint do you think? |
Thanks for your reply. Yes, the namespace in the test.py is used in your code. |
I was thinking about doing what you said, but I realied if we moved the parser arguments inside Lines 204 to 206 in f05934f
|
So sorry about that. And thank you for the reply. I was confused about the scope of the namespace before. Now I realize that the first namespace could be used in train.py, and would be used in test.py. And the scope of the second namespace is test.py. |
Resolved with PR #45. |
line 24 in train.py
import test
makes line 9~20 may not work.And it outputs two namespaces, which are
Maybe put line 7~19 in
test.py
insideif __name__ == '__main__':
could be better.The text was updated successfully, but these errors were encountered: