Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials should *not* be stored in plaintext, much less synced into GitHub as a public gist #482

Closed
ELLIOTTCABLE opened this issue Sep 27, 2023 · 1 comment · Fixed by #515
Assignees
Labels
enhancement New feature or request

Comments

@ELLIOTTCABLE
Copy link

At the moment, this (and several other drivers) store creds in plaintext — and worse, when Settings Sync is enabled, they can get sync'd to a public GitHub gist.

(See: mtxr/vscode-sqltools#210, mtxr/vscode-sqltools#479, mtxr/vscode-sqltools#927 …)

There's a new-ish API upstream that you can use for this, to properly behave as an AuthenticationProvider; see mtxr/vscode-sqltools#1066 for an example implementation.

This is pretty critical for us, ugh; but please don't take that too aggressively — I recognize this is a best-effort FOSS project. Take care of yourself. 💜

@ultram4rine ultram4rine self-assigned this Oct 9, 2023
@ultram4rine ultram4rine added the enhancement New feature or request label Oct 9, 2023
@ultram4rine
Copy link
Owner

Hi @ELLIOTTCABLE, I hope this will be fixed in #515.

Btw, vscode has built-in settings-sync feature, so you doesn't need to use extension that pushes them to Gist.

Btw2, my gist was private:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants