Support for Thymeleaf 3.0 #68

ultraq · 2015-04-14T22:15:30Z

ultraq · 2015-09-26T23:05:40Z

In-flight "docs" for the new dialect API: thymeleaf/thymeleaf#401

ebussieres · 2015-10-27T14:35:20Z

Is there an ETA for layout dialect to work with thymeleaf 3.0 ? I would like to try thymeleaf 3 alpha with layout dialect.

ultraq · 2015-10-28T07:52:21Z

I'm actually waiting for a beta version to start dev work - the API just kept changing during the alpha! That should be soon now though if talk on the Thymeleaf GitHub is anything to go by (eg: thymeleaf/thymeleaf#380 (comment))

ebussieres · 2015-10-28T11:25:27Z

All right thank you for your quick response :)

marcosbis · 2015-11-01T21:10:11Z

Hi there,
Have you got any updates about Layout Dialect supporting the new thymeleaf 3.0, I think beta01 version was released last week.

Thanks!

ultraq · 2015-11-03T10:24:39Z

It'll still be a while - I only just created a new code branch for 3.0 development and updated the build to download the 3.0 beta.

Fornori · 2015-12-01T10:25:40Z

Hello. Any news about support 3.0Beta1?

robertobsc · 2015-12-05T13:50:08Z

Hello @ultraq ! Looking foward to your dialect support for 3.0 beta!

beradrian · 2015-12-08T13:14:29Z

+1

michaelhaessig · 2016-01-22T13:46:55Z

Are there any news on the update progress ?

ultraq · 2016-01-24T08:53:22Z

Hey peeps, still nothing. I've only managed to update my other dialects to have snapshots with the 3.0 beta as an exercise to become more familiar with how Thymeleaf 3.0 does things. The architecture is quite different, and a lot of what I did in Thymeleaf 2.x I can't do here, so I'm having to come up with new ways of doing things.

ultraq · 2016-01-24T09:04:30Z

For future reference, any progress (or lack thereof), can be found in the thymeleaf-3.0 branch of this project.

xaph · 2016-02-19T08:28:47Z

hi @ultraq thanks for dev branch but maven can't resolve 2.0.0-SNAPSHOT version.

Do you have any plan on releasing new version?

eddumelendez · 2016-02-29T09:42:40Z

I am working in the integration with spring-boot spring-projects/spring-boot#4393 and we will need it.

yvanavermaet · 2016-03-27T00:00:27Z

Any update? If you need a hand with functional testing, I'd be happy to help.

ptahchiev · 2016-04-18T15:37:23Z

+1

ultraq · 2016-05-07T04:03:55Z

First 2.0.0-SNAPSHOT uploaded with only the few features checked on the list I've added to the original post.

Basically, only XML document decoration which doesn't include having to copy directives (eg: DOCTYPEs or comments) outside of the root elements, eg: this test file: https://github.com/ultraq/thymeleaf-layout-dialect/blob/thymeleaf-3.0/Tests/nz/net/ultraq/thymeleaf/tests/decorators/xml/Document-XmlDecoration.thtest

linux-china · 2016-05-09T03:15:58Z

+1

tobiasflohre · 2016-05-11T11:09:28Z

+1

ultraq · 2016-05-16T11:46:23Z

Just an FYI to anybody watching: the latest 2.0.0-SNAPSHOT now has as many features in it as the original version 1.0 of the layout dialect, so it may be useful to someone out there to play around with.

rakpan · 2016-05-17T16:32:01Z

+1

robvanderboom · 2016-05-19T20:26:28Z

Hi,
how can i already use 2.0.0.-SNAPSHOT in pom.xml ?
have dependency (see below) but it doesn'nt work.
Is there other way i can already use the snapshot ?

nz.net.ultraq.thymeleaf thymeleaf-layout-dialect 2.0.0-SNAPSHOT

ultraq · 2016-05-20T09:59:42Z

@robvanderboom, you can follow the instructions in this section here to enable access to the snapshot repositories: http://www.thymeleaf.org/faq.html#use-snapshot

robvanderboom · 2016-05-22T07:44:42Z

Thanks a lot, yes this is ok now.
However (i am employee and upgrading from 2->3) i get an exception every time i use a "/" :

... etc.

If i place 2col_wide_left one level up and define it as "2col_wide_left" it goes ok.
But then on other places like "data:addurl="${/add-interest}" it failes with exact same exception. It 'looks' like everywhere i use the slash it sees is as a wrong expression....
Don't know if concerns the layout-dialect snapshot, don't think so, but also don't know were to report this bug, since nothing to find about this issue. And it is a project that i only upgrade to newer version and did all code changes suggested in Thymeleaf 3 manual.

org.thymeleaf.exceptions.TemplateProcessingException: Could not parse as expression: "layout/2col_wide_left" (template: "page/login" - line 2, col 11)
org.thymeleaf.standard.expression.StandardExpressionParser.parseExpression(StandardExpressionParser.java:131)
org.thymeleaf.standard.expression.StandardExpressionParser.parseExpression(StandardExpressionParser.java:62)
org.thymeleaf.standard.expression.StandardExpressionParser.parseExpression(StandardExpressionParser.java:44)
org.thymeleaf.standard.expression.IStandardExpressionParser$parseExpression.call(Unknown Source)
nz.net.ultraq.thymeleaf.expressions.ExpressionProcessor.process(ExpressionProcessor.groovy:52)
nz.net.ultraq.thymeleaf.expressions.ExpressionProcessor$process.call(Unknown Source)
nz.net.ultraq.thymeleaf.decorators.DecoratorProcessor.doProcess(DecoratorProcessor.groovy:87)
org.thymeleaf.processor.element.AbstractAttributeModelProcessor.doProcess(AbstractAttributeModelProcessor.java:76)
org.thymeleaf.processor.element.AbstractElementModelProcessor.process(AbstractElementModelProcessor.java:98)
org.thymeleaf.util.ProcessorConfigurationUtils$ElementModelProcessorWrapper.process(ProcessorConfigurationUtils.java:649)
org.thymeleaf.engine.ProcessorTemplateHandler.handleOpenElement(ProcessorTemplateHandler.java:1499)

tobiasflohre · 2016-05-22T08:09:34Z

@robvanderboom I also stumbled over this exception. It seems that from Thymeleaf 3 you have to put literals between single quotes, otherwise it is treated as an expression. So try
layout:decorator="'layout/2col_wide_left'"
instead of
layout:decorator="layout/2col_wide_left"

ultraq · 2016-05-22T09:31:59Z

@robvanderboom, @tobiasflohre's suggestion seems legit, but this speaks to me of maybe some undesired behaviour from the expression engine if it suddenly can't interpret fragment paths with a / in them. Has an issue been raised against the Thymeleaf project for that change in behaviour?

Also, with the 2.0.0-SNAPSHOT versions, I've tried interpreting the value that goes into layout:decorator as an expression (in 1.x it was treated as a straight out string), but if it has this effect, then I might change that back in a future snapshot...

robvanderboom · 2016-05-22T09:37:35Z

The additional single quote helps for layout:decorator, but seems have to do this also for attributes like data:addurl="@{/add-interest}". Try to do all and see whats happining. But seems indeed that the expression engine is doing something strange and this isn't the final solution... Keep you updated...

robvanderboom · 2016-05-22T18:45:37Z

don't know were to start with this issue. It seems there is something new in Thymeleaf three that wants to see everything as an expression :->
For example i have a template with a <span data:title="${article.title}"></span>
It then gives an exception org.thymeleaf.exceptions.TemplateProcessingException: Could not parse as expression: "example title". So this means it first translates its to the correct article's title and then again wants to parse this result as an expression.... So first i thought it was only with the "/" but now it looks like there is a second layer parsing everything again ....

ultraq · 2016-05-23T09:01:30Z

That last bit about the data:title you might need to bring up with the makers of the data attribute dialect (https://github.com/mxab/thymeleaf-extras-data-attribute).

tobiasflohre · 2016-05-23T11:44:30Z

@ultraq I'm checking the Snapshot implementation currently, and I found out that the template which is used to decorate (surround) our main template is loaded four times:

one time completely at DecoratorProcessor 92
one time with selector head at HtmlDocumentDecorator 72
one time with selector body at HtmlDocumentDecorator 101
one time with selector html at HtmlDocumentDecorator 119

Do you think that's necessary? Couldn't you clone the one loaded the first time? We have remote access for the template, so we have a little performance issue with that.

ultraq · 2016-05-23T11:46:34Z

Hi @tobiasflohre, could you please raise a separate issue for that? I'm starting to think this one might get swamped if we try to track everything in the snapshot against it.

tobiasflohre · 2016-05-23T12:33:50Z

Yes, that's better. Here it is: #108

robvanderboom · 2016-05-30T19:53:00Z

My upgrade to 3.0 does go without issues, one is solved now in the thymeleaf attribute extra lib (version 2.0.1). Now in my current project the contents disappears because of the layout:decorator. Below a part of the code that is working in version thymeleaf 2 ?
WHen i remove the layout:decorator my is in the result of the page.
But with the layout:decorator the result is ... so empty...
Is Thymeleaf 3 more strict, and if so, where do i find this specs...

Tried a lot of thinks but content is always empty with the decorator...
I use version 2.0-snapshot of the dialect layout.

PS: even when the template 2col_wide_left is empty (or whatever is placed in it), the head-content is not showing up anymore, and without it it is ....

!DOCTYPE html>
<html xmlns:th="http://www.thymeleaf.org"
      xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout"
      layout:decorator="'layout/2col_wide_left'">
    <head>
        <title>Title</title>
        [everything i put here like a href to load css is removed from the result ]
    </head>
    <body>
.... etc.

robvanderboom · 2016-05-31T06:32:49Z

And as addon to above: is this the right place for my problem or should i crreate a new issue for this ? In my opinion it is a Or a bug Or a missing migration step in the "3 minutes guides". This sinces the migration guides steps are all followed and it is working in thymeleaf 2 (this construction is used througout the production website). So if it is not a bug of the layout dialect lib, it should explain why this part is not working anymore after migration (so what do i have to change ??) in the migration part.

ultraq · 2016-05-31T08:58:57Z

Hi @robvanderboom, I was just about to ask that you open another issue for this, so please do 😃

robvanderboom · 2016-05-31T21:48:13Z

Thanks @ultraq, i did: #111

bkontur · 2016-06-06T10:17:17Z

when this new-release-for-thymeleaf-3 will be released ?
thx

ptahchiev · 2016-06-06T10:25:29Z

It would be nice to have this in spring-boot 1.4 (which is scheduled to come some time around 20th of June). And I know for sure the spring-boot team is depending on this layout dialect.

spring-projects/spring-boot#4393

ultraq · 2016-06-22T10:31:29Z

The 2.0 snapshot now has feature parity with the latest of the 1.x branch! 😀

There's still a bit of work to be done, namely: a few edge case tests that I've accumulated during the 1.x lifetime (some devs using the layout dialect in ways I never thought of!), bugs/regressions that people have brought forward during their testing of the 2.0 snapshots, and a decent amount of documentation to update. Some of these are associated with the 2.0 milestone, so anybody curious about those can check the milestone.

Almost there!

ultraq added the enhancement label Apr 14, 2015

ultraq self-assigned this Apr 14, 2015

ultraq added this to the Thymeleaf Layout Dialect 2.0 milestone Apr 14, 2015

ultraq changed the title ~~Make the Layout Dialect compatible with Thymeleaf 3.0~~ Support for Thymeleaf 3.0 Apr 14, 2015

ultraq mentioned this issue Jan 24, 2016

Update readme for Thymeleaf 3.0 #93

Closed

ultraq added the breaking change label Feb 13, 2016

eddumelendez mentioned this issue May 9, 2016

Support Thymeleaf 3 spring-projects/spring-boot#4393

Closed

ultraq mentioned this issue Jun 4, 2016

layout:decorator can be work when the value is "layout"，but not work with "folder/layout" #112

Closed

ultraq closed this as completed Jun 22, 2016

Support for Thymeleaf 3.0 #68

Support for Thymeleaf 3.0 #68

Comments

ultraq commented Apr 14, 2015 • edited

ultraq commented Sep 26, 2015

ebussieres commented Oct 27, 2015

ultraq commented Oct 28, 2015

ebussieres commented Oct 28, 2015

marcosbis commented Nov 1, 2015

ultraq commented Nov 3, 2015

Fornori commented Dec 1, 2015

robertobsc commented Dec 5, 2015

beradrian commented Dec 8, 2015

michaelhaessig commented Jan 22, 2016

ultraq commented Jan 24, 2016

ultraq commented Jan 24, 2016 • edited

xaph commented Feb 19, 2016

eddumelendez commented Feb 29, 2016

yvanavermaet commented Mar 27, 2016

ptahchiev commented Apr 18, 2016

ultraq commented May 7, 2016

linux-china commented May 9, 2016

tobiasflohre commented May 11, 2016

ultraq commented May 16, 2016

rakpan commented May 17, 2016

robvanderboom commented May 19, 2016

ultraq commented May 20, 2016

robvanderboom commented May 22, 2016 • edited

tobiasflohre commented May 22, 2016

ultraq commented May 22, 2016

robvanderboom commented May 22, 2016

robvanderboom commented May 22, 2016 • edited by ultraq

ultraq commented May 23, 2016

tobiasflohre commented May 23, 2016

ultraq commented May 23, 2016

tobiasflohre commented May 23, 2016

robvanderboom commented May 30, 2016 • edited

robvanderboom commented May 31, 2016

ultraq commented May 31, 2016

robvanderboom commented May 31, 2016

bkontur commented Jun 6, 2016

ptahchiev commented Jun 6, 2016

ultraq commented Jun 22, 2016

ultraq commented Apr 14, 2015 •

edited

ultraq commented Jan 24, 2016 •

edited

robvanderboom commented May 22, 2016 •

edited

robvanderboom commented May 22, 2016 •

edited by ultraq

robvanderboom commented May 30, 2016 •

edited