Separation of public and private header files

[db-tech]

wouldn't it be nice to separate header files needed externally and those only needed internally?
Maybe put all internal cpp and header files needed only internally together into the src directory and the public header into include/uvgRTP ?

[altonen]

Hi,

yes it would be nicer but I personally don't see it as a huge issue that they are all in the same directory. If you want this to be changed, please open a pull request.

[db-tech]

If you consider accepting this style, I will create a PR

[jrsnen]

I would also consider this an improvement. Thank you for the suggestion.

[jrsnen]

What is the situation on the PR? I could attempt to do this. It seems there are some header dependencies that would probably need to be eliminated.

[db-tech]

Wanted to start with that next week. But if you have the time, be my guest :-)
Then I would do issue #13.
That kind of depends on this one.
If you start with it and need some input or help, let me know.

[jrsnen]

I'm sorry, but this proved to be too big of a task for me at this point. I managed to reduce header dependencies, but there is no clear API defined in uvgRTP, which makes it hard to determine which headers are necessary and which are not. In addition, I was not able to remove all the dependencies (in rtcp.hh) which makes it difficult to eliminate those headers. I'll update my changes so far this week.

@altonen Do you have a list of which headers are necessary to use the library and which are meant to be internal headers? For example, I sow the need to free the frame using function from frame.hh which I thought was internal.

[jrsnen]

I updated the repo with reduced header dependencies.

lib.hh now includes all the header files since I didn't know which ones were required. This is basically the same as before because of the header dependencies.

[jrsnen]

After a discussion with @altonen, we settled on a list of headers that are needed in the include folder. There are few extra because of rtcp.hh, but in general decde85 is a big improvement on this matter. Feel free to improve it further if you have ideas.

[db-tech]

Awesome, i will take a Look tomorrow.

[db-tech]

I did a minimalistic check of the commit. I would need more time to check if we could do more Improvements. Unfortunately, I am not able to be more thorough at the moment.

I still have some comments:

1. I would consider creating a subdirectory uvgrtp in the include directory. That would be nicer in the internal include statements and easy to distinguish between private and public header.
2. I would try to avoid relative include paths like this "../xyz.hh" but rather adding the src dir to the private include paths in cmake.

[jrsnen]

I create a separate issue for your comment 2. Comment 1 should be implemented and is related to this issue.

[jrsnen]

Merged with #44