Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate ZRTP message operation from message constructors #50

Closed
jrsnen opened this issue Jul 1, 2021 · 0 comments
Closed

Separate ZRTP message operation from message constructors #50

jrsnen opened this issue Jul 1, 2021 · 0 comments
Labels
dev Developing uvgRTP is easier, but these features are not visible to users of the library

Comments

@jrsnen
Copy link
Member

jrsnen commented Jul 1, 2021 •
edited

I don't think it is a good idea to do all the functionality of a zrtp message in its constructor. The operations should be separated to at least a separate function that is called. This change is not trivial since the messages are already using this logic.

This affects all ZRTP message types.
@jrsnen jrsnen added the feature New feature label Jul 1, 2021
@jrsnen jrsnen added dev Developing uvgRTP is easier, but these features are not visible to users of the library and removed feature New feature labels Jul 14, 2021
@jrsnen jrsnen closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Developing uvgRTP is easier, but these features are not visible to users of the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrsnen