Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support for the UI #1

Closed
lwcorp opened this issue May 7, 2021 · 7 comments
Closed

Unicode support for the UI #1

lwcorp opened this issue May 7, 2021 · 7 comments

Comments

@lwcorp
Copy link

lwcorp commented May 7, 2021

SC's UI is not in Unicode and thus can be presented only in Latin letters. When you try other letters it looks like Gibberish:
image

Someone in https://forum.ultravnc.net/viewtopic.php?t=31822 successfully patched it to support Unicode, so the same screen above will look like:
image

Can someone use that user's code (or for that matter another code) to submit an official patch here?

@RudiDeVos
Copy link
Member

Done in SC_20

@lwcorp
Copy link
Author

lwcorp commented Aug 13, 2022

Done in SC_20

Thanks! But why wasn't https://uvnc.com/products/uvnc-sc/78-ultravnc-sc-online-creator.html updated?

Also didn't find such a source code (see #3).

@RudiDeVos
Copy link
Member

The sourcecode of winvnc is the same as the SC code.
https://github.com/ultravnc/UltraVNC/releases/tag/SC_20_dev1
It's just build using other precompile options.
(when building select SC_20 or SC_20_DEBUG)

https://forum.uvnc.com/viewtopic.php?p=111053#p111053

It's still in dev, when moved to release a new creator page will be created as some parameters differ.

@lwcorp
Copy link
Author

lwcorp commented Aug 13, 2022

Sounds good, maybe it'll also fix https://forum.uvnc.com/viewtopic.php?t=35217 ?

But please see notes in #3.

@RudiDeVos
Copy link
Member

First waiting a little for feedback.
This version doesn't have separated dll's. The encryption plugin en ddengine are embedded in the exe and executed from memory. New creators are needed.

You can easy test it, put the helpdesk.txt next to the SC version and run SC.
Once i know SC does what is has todo en new online creator will be made, to soon now.

Internal, a lot of changes were needed to have one sourcetree, with the risk that some mistakes were made.
It was the only way to keep SC in sync and support the same encoder and options has the full version. The integration was 3 months of work.
You find them in the code
#ifdef SC_20
#endif

@lwcorp
Copy link
Author

lwcorp commented Aug 13, 2022

Thanks for all your hard work! Feedback might come by people who analyze the source code.

I assume you mean the new helpdesk.txt from https://github.com/ultravnc/UltraVNC/tree/SC_20_dev1/winvnc/winvnc/SC_20.
But how to get the new winvnc.exe to put it there too?
And what about all the images from the past (like logo.bmp)? Are they not needed anymore?

@RudiDeVos
Copy link
Member

RudiDeVos commented Aug 13, 2022

The download link was on the forum
https://forum.uvnc.com/viewtopic.php?t=37641
This contain the correct exe and helpdesk.txt to test
https://www.uvnc.eu/download/1390/UltraVNC_139%20dev1.zip
image

Did some testing.
logo.bmp, background.bmp works
enter.bmp : not longer used (site panel is now opened to enter the code)
icons are replaced with the online creator using a resource replacer, will not work running in this test.

Encryption: you can add the public(server) encryption key
Enmbedded encryption is "SecureVNCPlugin", you need to use a viewer to created the keys.
Add the server key in the winvnc folder and the viewer key in the viewer folder.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants