New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests from fs_test.go do not work on Windows #7

Closed

PlkMarudny opened this issue Jul 9, 2017 · 1 comment

PlkMarudny commented Jul 9, 2017

In line 21 there is a statement:

filename := path.Base(file.Name())

while it should be

filepath.Base(file.Name())

to handle filesystem path on Linux and Windows (filepath is imported from 'path/filepath')

The text was updated successfully, but these errors were encountered:

Member

thoas commented Jul 9, 2017

we don't plan to support Windows, you can send a PR if you want.

thoas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment