Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Adding new method Inc under drivers to allow rate limiting based on given variable count #172

Merged
merged 2 commits into from Nov 17, 2021

Conversation

Harry-027
Copy link
Contributor

### Description

This is regarding the issue raised before to support advanced use cases.
Raising PR to expose new method in order to increment Lua script counter by the number provided by user. This will facilitate and extend the library functionality to support rate limiting graphql apis based on query complexity.

Copy link
Contributor

@novln novln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really nitpicking comment, sorry in advance.
Could you change Inc to Increment in the interface declaration?

Otherwise look good for me 👍

Thank you for your contribution 🙂

@Harry-027
Copy link
Contributor Author

Harry-027 commented Nov 17, 2021

A really nitpicking comment, sorry in advance. Could you change Inc to Increment in the interface declaration?

Otherwise look good for me 👍

Thank you for your contribution 🙂

Thanks @novln ! I have made the required change. Could you release this as part of v3, since it's just an enhancement ? Would be really helpful if this is made available as soon as possible. Will be able to use this directly instead of maintaining my own fork 🙂

@novln novln merged commit dbafe13 into ulule:master Nov 17, 2021
@novln
Copy link
Contributor

novln commented Nov 17, 2021

Hello,

There is a new release: https://github.com/ulule/limiter/releases/tag/v3.9.0

Thank you again for your contribution 🙂

@Harry-027
Copy link
Contributor Author

Hello,

There is a new release: https://github.com/ulule/limiter/releases/tag/v3.9.0

Thank you again for your contribution 🙂

Thanks @novln for releasing this 🚀 Much appreciated 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants