Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README is wrong #24

Closed
Zamiell opened this issue Sep 24, 2017 · 0 comments
Closed

README is wrong #24

Zamiell opened this issue Sep 24, 2017 · 0 comments

Comments

@Zamiell
Copy link

Zamiell commented Sep 24, 2017

Docs are wrong.

// Or use a in-memory store with a goroutine which clears expired keys every 30 seconds
store := limiter.NewMemoryStore("prefix_for_keys", 30*time.Second)

According to the code it doesn't take any arguments, so this should just read:

// Or use a in-memory store
store := limiter.NewMemoryStore()

// Alternatively, use a in-memory store with some extra configuration
store := limiter.NewMemoryStoreWithOptions(???)

Something like that anyway.

@thoas thoas closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants