Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add ability to bundle settings for organization deployment #2

Open
franckadil opened this issue Jul 21, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@franckadil
Copy link

Hi! I really love the work done here! Is it possible to bundle the AWS settings inside the app for automated distribution ? This would allow to not disclose the AWS credentials and may be useful foe many case scenarios (organization deployment ...) Thank you for looking into this!

@ulver2812
Copy link
Owner

ulver2812 commented Jul 25, 2019

Hi, yes, it's possible.

First Solution

If you need this feature immediately you can clone the repo and change the file "src/app/providers/aws.service.ts" at line 55 and 86 in this way:

let settings = this.settings.getSettings();
settings.awsAccessKeyID = 'YOUR ACCESS KEY ID';
settings.awsSecretAccessKey = 'YOUR SECRET ACCESS KEY';

Then build the app with bundled credentials.

Second Solution

But I think that the best way to achive this is to set the aws credentials through the AWS CLI. You need to add this code after line 54, same file above:

return new Promise<boolean>(resolve => {
   resolve(false);
});

and delete lines from 87 to 89.

Then build the app and before use it configure the AWS CLI with the correct credentials and region (https://docs.aws.amazon.com/en_us/cli/latest/userguide/cli-chap-configure.html#cli-quick-configuration).

In this way you can hide the credentials through the AWS CLI without expose them in the app.

I didn't test the code changes above, try them on a test machine before use the modified app in production.

I will add this feature directly in the app in my free time.

If you want, you can fork the repo and work to add this feature in the app and then submit a pull request.

I my opinion the best way to add this feature is to add an option in the settings page, maybe a checkbox, to give the user the choiche to use exposed credentials or set them through the AWS CLI.

Thanks for the contributions

@ulver2812 ulver2812 added the enhancement New feature or request label Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants