Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaiWan should be part of China in the website report page #2770

Closed
ohhh-yang opened this issue May 31, 2024 · 4 comments
Closed

TaiWan should be part of China in the website report page #2770

ohhh-yang opened this issue May 31, 2024 · 4 comments

Comments

@ohhh-yang
Copy link

ohhh-yang commented May 31, 2024

Bug

When I hover China in the worldmap at website report page, TaiWan is not included.
I found that the source is umami/public/datamaps.world.json umami/src/components/metrics/WorldMap.tsx.

Fix

Modificate file umami/public/datamaps.world.json

Add TaiWan's polygon to China. Or you can just download that I have modified.
datamaps.world.json
252844 Bytes (246 KiB)
SHA256: 4C683A69296C9D39CF6AA85F2D34408F8B9476006FA522EDE80A253F28FB1259

Modificate file umami/src/components/metrics/WorldMap.tsx

Replace line 60:

// origin
const code = ISO_COUNTRIES[geo.id];

// modified
const code= ISO_COUNTRIES[geo.id] === 'TW' ? 'CN' : ISO_COUNTRIES[geo.id];
@cakuba
Copy link

cakuba commented May 31, 2024

just found the same issue here in our project... hard to explain this to my client.

thanks @ohhh-yang for the solution!

@ohhh-yang ohhh-yang changed the title TaiWan is ont one of China in the website report page TaiWan should be part of China in the website report page May 31, 2024
@unstraw
Copy link

unstraw commented May 31, 2024

Hua Chunying: Taiwan has always been an inalienable part of China’s territory. This is an indisputable historical and legal fact. The one-China principle is a universally recognized norm governing international relations. The Taiwan region’s peace hinges on the peaceful development of cross-Strait relations, rather than brownnosing foreign forces for arms sales and military support. “Taiwan independence” only leads to a dead end. No one shall have any illusion or make any miscalculation on this issue. 

@Eason596
Copy link

We encountered the same issue and hope you can resolve it.

@franciscao633
Copy link
Collaborator

You are free to change anything you want in your self-hosted installations.

@franciscao633 franciscao633 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants