Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and Hide Jumpy #59

Closed
adfleshner opened this issue Oct 17, 2013 · 7 comments
Closed

Show and Hide Jumpy #59

adfleshner opened this issue Oct 17, 2013 · 7 comments

Comments

@adfleshner
Copy link
Contributor

Is there a method that I am missing that can show and hide the panel view like in google maps so that the entire view doesn't re-size and jump on showPane() and hidePane(). More like the panel is on top and not apart of it like that acitionbar when you add true?

@tokudu
Copy link
Contributor

tokudu commented Oct 31, 2013

Have a look at the example. It shows how to accomplish what you want.

@tokudu tokudu closed this as completed Oct 31, 2013
@adfleshner
Copy link
Contributor Author

I have looked at the example line by line and there is nothing currently in that project. in the java file or the xml file that specifies how to overlay the SlideUpPanel I already have the actionbar as an overlay and it works amazingly but when I showPane() and hidePane() the layout is squished and expanded. Again I am not talking about the actionbar, I am talking about the pane that you created when that shows and hides. Its fine if its not built in just if it is please help me find where this code actually is. PS I am using a map.

Thank you for your time and your work its great.

@tokudu
Copy link
Contributor

tokudu commented Nov 1, 2013

I'm not sure I understand what you mean by the layout getting squished. Can you post a screenshot?

@adfleshner
Copy link
Contributor Author

https://www.youtube.com/watch?v=5iw8X6iUILk here is a video about the jumpy squish and expand I am talking about. And what I am curious about is if it is possible to do that they did with google maps where it acts like the action bar and just appears without the map view moving

@tokudu
Copy link
Contributor

tokudu commented Nov 1, 2013

ohhh, now I get it. Yeah, unfortunately, smooth animation for show/hide hasn't been implemented yet. It shouldn't be that hard to do tho. Have a a look at the mSlideRange parameter.

Anton

@AnujAroshA
Copy link

Hi guys, @adfleshner , @tokudu

I think I did it. Just comment 495 line in (https://github.com/umano/AndroidSlidingUpPanel/blob/master/library/src/com/sothree/slidinguppanel/SlidingUpPanelLayout.java) which is;

height -= panelHeight;

and you are good to go. But you will get possible drawback when you use Google Maps zoom-in zoom-out buttons if you use them. That is, the sliding up drawer will cover those buttons. But in real Google Maps it wont happen.

@adfleshner
Copy link
Contributor Author

I just tried it out and it worked beautifully. I'll be looking to add at adding custom animations shortly ( but that was what I was looking for ) I can see why it was written the other way for lists and such but for maps I honestly believe this is more correct. Thanks @AnujAroshA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants