Add target URL in CORS error message #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
reviewed
Jul 24, 2023
umap/static/umap/js/umap.xhr.js
Outdated
| @@ -95,7 +95,7 @@ L.U.Xhr = L.Evented.extend({ | |||
| // 0 === request cut by user or CORS | |||
| self.ui.alert({ | |||
| content: L._( | |||
| 'Issue reaching that URL (network problem or CORS protection)' | |||
| 'Issue reaching that URL (network problem or CORS protection)' + ` ${settings.uri}` | |||
There was a problem hiding this comment.
Suggested change
| 'Issue reaching that URL (network problem or CORS protection)' + ` ${settings.uri}` | |
| `Issue reaching that URL (network problem or CORS protection) ${settings.uri}` |
There was a problem hiding this comment.
Why not, even if this means that every languages would need an update, but in that case I'd better add a variable, to keep the string "simple" for translators. I'll do that :)
davidbgk
approved these changes
Jul 24, 2023
yohanboniface
force-pushed
the
url-in-cors-message
branch
from
44d54bc
to
831d09c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1226