Edit header revamp #1233
Edit header revamp #1233
Conversation
umap/static/umap/js/umap.js
Outdated
| container | ||
| ) | ||
| cancel.href = '#' | ||
| cancel.title = L._('Cancel edits') | ||
| cancel.textContent = L._('Cancel') | ||
| cancel.textContent = `${L._('Cancel all')} (Ctrl+Z)` |
There was a problem hiding this comment.
I'm more inclined to standardize the keyboard shortcuts between brackets [ctrl+z], not sure if the <kbd> tag would help assistive technologies.
What about macOS devices? 😈 (more accustomed to cmd+z)
There was a problem hiding this comment.
I'm more inclined to standardize the keyboard shortcuts between brackets [ctrl+z]
Should I do that in a separate PR ? AFAIK we use parenthesis everywhere ATM.
not sure if the tag would help assistive technologies
Ah, could be nice! But now those are inside the title attribute, so that would need dealing with our own tooltips I guess.
|
"Mobile" mode:
There is still the "Disable editing" that does not fit when screen get smaller, but this is already the case, so I'd say we can deal with it later (need an icon, or at least a new wording, cf #556 ) |
cf #609