Add experimental drag and drop of file on the map container #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure flat-drop-file is necessary but I would provide an affordance on 
(from https://iconsvg.xyz/ ) |
|
Following discussion with @yohanboniface where it seems that the dragndrop was failing on chromium and chrome, I can say that it's working well for me on chrome and firefox with this branch. uname -a
22.6.0 Darwin KernelVersions :
|
|
Also installed umap on an Arch machine and tried this there, and it was working as intended (with Firefox and Chromium, same versions) I've been using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2023-10-13.11-42-04.webm
fix #231
Very basic. Should we yet introduce https://github.com/placemark/flat-drop-files helper ?