Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom storage instead of django-compressor #1539

Merged
merged 3 commits into from Jan 17, 2024
Merged

Conversation

davidbgk
Copy link
Contributor

@davidbgk davidbgk commented Jan 16, 2024

This is a really early stage.

  • Deal with the commented favicon.ico which tries to reach staticfiles_storage.url("umap/favicons/favicon.ico")
  • Check that all paths are well rewritten
  • Handle dynamic {locale}.js path, not sure how it can work, maybe with intermediary variable?
  • Fix tests :)

The support_js_module_import_aggregation toggle + wrong regexps for our prettier semicolons-less config were hard to find!

@yohanboniface
Copy link
Member

Deal with the commented favicon.ico which tries to reach staticfiles_storage.url("umap/favicons/favicon.ico")

I'm missing the issue here: it seems to work well locally, either with DEBUG=True or False and using an nginx proxy, the path to favicon.ico seems to be updated in the served HTML, I see that even favicon.ico exists in the static dir, so even if some browser wants that path explicitly it will find it. So I guess I'm missing the point ;)

@davidbgk
Copy link
Contributor Author

So I guess I'm missing the point ;)

Well, in a previous attempt it was an issue during the collectstatic command, maybe another setting was wrong because now it works for me too!

@davidbgk
Copy link
Contributor Author

now it works for me too!

Not so fast, tests are failing because of that.

@yohanboniface yohanboniface marked this pull request as ready for review January 17, 2024 17:45
@yohanboniface yohanboniface merged commit 016f747 into master Jan 17, 2024
4 checks passed
@yohanboniface yohanboniface deleted the no-compressor branch January 17, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants