refactor: Separate ui rendering from data updates #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
force-pushed
the
schema-impacts
branch
2 times, most recently
from
a2b3ad5
to
e817948
Compare
davidbgk
reviewed
Mar 16, 2024
davidbgk
reviewed
Mar 16, 2024
almet
force-pushed
the
schema-impacts
branch
2 times, most recently
from
93d47e2
to
1990cb6
Compare
|
This is ready to be merged! |
davidbgk
reviewed
Apr 2, 2024
yohanboniface
approved these changes
Apr 15, 2024
| @@ -0,0 +1,185 @@ | |||
| import re | |||
There was a problem hiding this comment.
Maybe mv those tests in test_edit_map.py instead of having a new module ?
| @@ -1,397 +1,4 @@ | |||
| describe('L.Util', function () { | |||
There was a problem hiding this comment.
I'm surprised to see all those tests removed here ? Should this have been done in that other PR moving utils to a module ? Or is this just missing a rebase ?
There was a problem hiding this comment.
yep, it's broken in the current master, and fixed here! 🙈
`U.SCHEMA` now contains an `impacts` key, which makes it possible to specify what part of the UI is impacted by data changes. A new `render` method has been added on `U.Map` and `U.DataLayer`, which is used to rerender the proper parts of the UI depending on the passed properties. `U.FormBuilder` calls this `render()` method (if present), during form changes.
There are now multiple elements accessed with the same CSS selector.
It was currently looked for in the uMap utils, where it wasn't present.
Also: - move the `type` key before the `impacts` one. - avoid one-line objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U.SCHEMAnow contains animpactskey, which makes it possible to specify what part of the UI is impacted by data changes.A new
rendermethod has been added onU.MapandU.DataLayer, which is used to rerender the proper parts of the UI depending on the passed properties.U.FormBuildercalls thisrender()method (if present), during form changes.Note
This approach is less specific than a previous one in order to a) not tie the schema to specific callbacks and b) not repeat properties in two different places.
The resulting code is less conservative when considering which parts of the UI are updated when receiving updates, thus rerendering parts of the UI which might not be in need of rerender. The hope is that it won't be a problem, but let's keep our eyes open.
Progress
ChoroplethLayer.onEditis expecting to be passed the builderimpacts = []everywhere (remove['']occurrences)