Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script flag arguments are consumed by vr #26

Closed
han-tyumi opened this issue May 23, 2020 · 6 comments
Closed

Script flag arguments are consumed by vr #26

han-tyumi opened this issue May 23, 2020 · 6 comments
Labels
🐞 bug Something isn't working

Comments

@han-tyumi
Copy link

Currently when trying to pass flag arguments to my script they are instead consumed by vr.

image
Expected

image
Actual

@umbopepato
Copy link
Member

@han-tyumi thanks for reporting this.

Looks like the CLI framework consumes unknown options (positional arguments should work though).
Until this is fixed I can suggest you to use version 1.0.0-beta.3 in order to forward options correctly to scripts:

deno install --allow-read --allow-env --allow-run -f -n vr https://deno.land/x/velociraptor@v1.0.0-beta.3/cli.ts

@umbopepato umbopepato added the 🐞 bug Something isn't working label May 24, 2020
@umbopepato
Copy link
Member

@han-tyumi this should be solved in v1.0.0-beta.8. I'll leave you to close this if it works

@umbopepato umbopepato reopened this May 25, 2020
@han-tyumi
Copy link
Author

@umbopepato Just tested your changes; works correctly now. Thanks!

@Nisgrak
Copy link

Nisgrak commented May 30, 2020

Didn't work in 1.0.0-beta.9

@umbopepato
Copy link
Member

umbopepato commented May 30, 2020

@Nisgrak are you getting the Unknown option error?
Can you show the complete vr command you're running?

@Nisgrak
Copy link

Nisgrak commented Jun 1, 2020

@umbopepato I tested again and it's work, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants