Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer does not copy UmbracoCommerceCheckout folder to App_Plugins #1

Closed
pageorge opened this issue Sep 7, 2023 · 14 comments
Closed

Comments

@pageorge
Copy link

pageorge commented Sep 7, 2023

We are running Umbraco.Cms 10.5.1 with: Vendr 2.4.1, Vendr.Checkout 2.1.2, Vendr.PaymentProviders.PayPal" 2.0.1, Vendr.PaymentProviders.Stripe 2.0.1, Vendr.uSync 2.0.1.

After following the upgrade to Umbraco Commerce instructions on https://docs.umbraco.com/umbraco-commerce/how-to-guides/migrate-from-vendr-to-umbraco-commerce. When it came to installing Umbraco.Commerce.Checkout 10.0.0, the Settings page shows [ucc] and clicking it gives a 404 not found: /App_Plugins/UmbracoCommerceCheckout/backoffice/views/dashboards/installer.html so we could not install the new node/doc types/data types. Someone else reported the same issue on the Umbraco forum with no reply: https://our.umbraco.com/forum/using-umbraco-and-getting-started/112485-umbraco-commerce-and-umbraco-commerce-checkout-checkout-dashboard-throwing-errors

As this was blocking us from upgrading I tried building and publishing the support\10.x branch and manually copying \bin\Release\net6.0\publish\wwwroot (excluding App_Plugins\Umbraco.Licenses) to our App_Plugins folder and the Umbraco Commerce Checkout menu then appears, we could then click the Install button and the new ucc nodes/doc types/datatypes get created. All working fine from then on!

Thought I'd mention this in case there's an issue with the nuget package copying in to the App_Plugins folder or if this is now all done in C#....

Cheers
Phil

@mattbrailsford
Copy link
Contributor

The new Umbraco Commerce Checkout packages should be RCLs and so don’t distribute files on disk. It sounds like there could be an issue in v10 it not managing to resolve these.

I’ll take a look 👍🏻

@mattbrailsford
Copy link
Contributor

Ok, I think I found the issue. I think our build script wasn't quite updated properly when setting up the v10 build and so it wasn't actually embedding the static assets in the nuget file. I've updated this now and it appears they are now there. If you fancied testing this out, I've pushed a build to Umbraco's nightly feed 10.0.1--preview.6 if you wanted to try it out https://docs.umbraco.com/umbraco-cms/fundamentals/setup/install/installing-nightly-builds

@mattbrailsford mattbrailsford added this to the 10.0.1 milestone Sep 14, 2023
@mattbrailsford
Copy link
Contributor

Fixed in 10.0.1

@robertjf
Copy link

@mattbrailsford I'm seeing the same problem with Commerce 12.1.1 and Commerce.Checkout 12.0.0...

@mattbrailsford
Copy link
Contributor

mattbrailsford commented Oct 17, 2023

@robertjf just to be clear, are you saying the dashboards etc in the backoffice aren't displaying? or that the static assets just aren't on disk? The later is expected behavior due to the use of RCLs

@robertjf
Copy link

Hm. I may have misread the original issue - in my case, the front end css file is returning a 404 error. Not yet sure about any JavaScript assets...

@mattbrailsford
Copy link
Contributor

What OS are you running on?

@robertjf
Copy link

MacOS - Here's what appears to be missing (this is the front-end):
image

@mattbrailsford
Copy link
Contributor

Then bingo, I think that could be the issue. It looks like the path in the templates is set to /app_plugins/umbracocommercecheckout/... when it should be /App_Plugins/UmbracoCommerceCheckout/... so with MacOS being case sensitive, this will probably be why it's not being found.

@robertjf
Copy link

Aaaah - of course!

@mattbrailsford
Copy link
Contributor

Lemme create a new build and I'll push it to our nightly feed for you to try out

@mattbrailsford
Copy link
Contributor

Ok, there should be a 12.0.1 preview on the nightly feed now https://www.myget.org/F/umbraconightly/api/v3/index.json

@robertjf
Copy link

Thanks @mattbrailsford - that's fixed it :)

@mattbrailsford
Copy link
Contributor

Perfect. I'll get an update posted out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants