Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite issues #1008

Closed
Nuklon opened this issue Apr 14, 2023 · 3 comments
Closed

SQLite issues #1008

Nuklon opened this issue Apr 14, 2023 · 3 comments
Labels
release/10.3.3 release/11.1.3 state/in-sprint We've committed to work on this during the sprint indicated in the milestone type/bug

Comments

@Nuklon
Copy link

Nuklon commented Apr 14, 2023

On a fresh install:

  1. Various health checks fail (PKs and unique constraints). These seem related to the point below.
  2. Migration steps aren't working:
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the Key columns in UFFolders as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the Key columns in UFForms as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the Key columns in UFDataSource as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the Key columns in UFPrevalueSource as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the Key columns in UFWorkflows as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFRecordDataBit as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFRecordDataDateTime as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFRecordDataInteger as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFRecordDataLongString as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFRecordDataLongString as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserSecurity as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserFormSecurity as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserGroupSecurity as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserGroupFormSecurity as a primary key already exists.
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the User, Form columns in UFUserFormSecurity as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create unique constraint on the UserGroupId, Form columns in UFUserGroupFormSecurity as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserStartFolders as adding constraints to existing tables is not supported with SQLite.
[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserGroupStartFolders as adding constraints to existing tables is not supported with SQLite.

Reproduction

Install Umbraco 11.3 and Forms 11.1. Run Forms' health check and see console log.


This item has been added to our backlog AB#28501

@AndyButland
Copy link

I don't think this is a concern unless you are seeing missing primary keys in your tables as they are actually created. We have some migrations that are there to ensure keys that weren't previously defined when the database table was first introduced, but these can only run on SQL Server as we are limited to what we can change schema-wise with SQLite in a migration.

There are also some less critical but ideal to have constraints, that again we create for SQL Server.

So they are just an informational messages.

Please update though if you believe there's something important missing from the actual schema you have created.

@Nuklon
Copy link
Author

Nuklon commented Apr 14, 2023

I wasn't too worried about the unique constraints, but there's also a missing PK on UFUserSecurity.

[13:28:37 INF] Database migration step not completed: could not create primary key constraint on UFUserSecurity as adding constraints to existing tables is not supported with SQLite.

image

@AndyButland AndyButland added type/bug state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks state/in-sprint We've committed to work on this during the sprint indicated in the milestone and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Apr 14, 2023
@AndyButland
Copy link

This will be resolved for the next patch releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/10.3.3 release/11.1.3 state/in-sprint We've committed to work on this during the sprint indicated in the milestone type/bug
Projects
None yet
Development

No branches or pull requests

2 participants