Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace anchor elements with button elements #383

Closed
bjarnef opened this issue Aug 6, 2020 · 2 comments
Closed

Replace anchor elements with button elements #383

bjarnef opened this issue Aug 6, 2020 · 2 comments

Comments

@bjarnef
Copy link

bjarnef commented Aug 6, 2020

In Umbraco core many accessibility changes have been many.
One of them is replacing <a> (anchor) elements with <button> elements for buttons unless it is actually a link, but most are not.

It is also ideal to specifify type attribute since browsers may have different default behavior of <button> elements.
Most of the time <button type="button"> can be used.

Furthermore for icons using <i> element, it is also useful to specify aria-hidden="true".

@nul800sebastiaan
Copy link
Member

Thanks @bjarnef, I've put it on the list of things to look into when we're ready to work on accessibility issues.

@AndyButland
Copy link

These have been updated where identified (i.e. as noted in #107) and all purely decorative icons using <i> have had the aria-hidden="true" attribute added. Due in the upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants