Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Tab group - Unable to remove tab #753

Merged
merged 2 commits into from Mar 18, 2024

Conversation

JesmoDev
Copy link
Contributor

Fixes a bug that would break the tab group if you removed a tab.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard merged commit 07c0045 into v1/contrib Mar 18, 2024
9 of 11 checks passed
@iOvergaard iOvergaard deleted the v1/bugfix/tabs-unable-to-remove-tab branch March 18, 2024 09:08
iOvergaard pushed a commit that referenced this pull request Mar 18, 2024
* add story

* make sure to clean up the breakpoints array to prevent index overflows
@iOvergaard iOvergaard added bug Something isn't working documentation Improvements or additions to documentation labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants