Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set datatype by guid #67

Closed
bjarnef opened this issue Oct 27, 2023 · 3 comments
Closed

Set datatype by guid #67

bjarnef opened this issue Oct 27, 2023 · 3 comments

Comments

@bjarnef
Copy link

bjarnef commented Oct 27, 2023

It seems currently the SetDataType() has two overload methods:

SetDataType(string name)
SetDataType(int id)

but I think if would be great to have SetDataType(Guid id) as well if having multiple environments, where the id may not be identical and the downside with datatype name is that I guess it will break if the datatype instance is renamed :)

image

@bjarnef bjarnef added the bug Something isn't working label Oct 27, 2023
@bjarnef bjarnef changed the title SetDataType by uid Set datatype by guid Oct 27, 2023
@mattbrailsford mattbrailsford added enhancement and removed bug Something isn't working labels Oct 27, 2023
@bjarnef
Copy link
Author

bjarnef commented Oct 27, 2023

Btw. I opened this as a bug since the "Features and Ideas" opens:
https://github.com/outfielddigital/konstrukt/discussions

The "Support Question" and "Documentation Issue" may also need to be updated.

@mattbrailsford
Copy link
Contributor

mattbrailsford commented Oct 27, 2023

So I quickly added a fix and I've pushed a nightly to the Umbraco nightly feed if you'd like to try that https://docs.umbraco.com/umbraco-cms/fundamentals/setup/install/installing-nightly-builds 12.0.1--preview.5

@mattbrailsford
Copy link
Contributor

Implemented in 10.0.1 and 12.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants