Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reject an active workflow. activePermissions is undefined. #51

Closed
Fjellvang opened this issue Jan 3, 2024 · 4 comments
Closed

Comments

@Fjellvang
Copy link

When attempting to reject an active workflow nothing happens. Inspecting the console reveals that no activePermissions is set, hence the javascript fails.

Using Umbraco 13.0.3 and Workflow 13.0.1

Reproduction

  1. Install Umbraco 13.0.3 with the starter template.
  2. Install Workflow 13.0.1
  3. Create two approval groups
    • Proof Readers
    • Publishers
  4. Create two new users and attach them to each group.
  5. Add two groups to the new node approval flow.
  6. Create a new blog post and send to approval.
  7. Attempt to reject the workflow from any user.

image

@Fjellvang
Copy link
Author

I just tested on Umbraco 12.3.6 and workflow 12.2.2. Same issue.

I simply installed the 2 packages, including the starter pack. This time i made a single group and only added the default admin user. If i attempt to reject my own publish i get the same issue

@nathanwoulfe
Copy link

Hey @Fjellvang, I'll add this to the current sprint to investigate. Meanwhile, I'd appreciate if you could confirm this only happens when using the new-node workflow, and rejecting tasks where the configuration is set on the node works as expected.

Looking at the screenshot, the Group has no member message in the bottom-right Workflow activity component looks problematic and will likely point to the problem (group members are not being populated, so no permissions available, so no rejection).

@nathanwoulfe nathanwoulfe self-assigned this Jan 8, 2024
@Fjellvang
Copy link
Author

Fjellvang commented Jan 9, 2024

Hey @nathanwoulfe .

Im not sure why it reported that the group has no member, as i tested with both assigning an umbraco user group and assigning the members explicitly:
image

I only tested without license initially using the "new node flow". If i approve the new node flow, and then request new changes choosing an approval group manually, then that group can correctly decline changes.

If i enable testlicense and assign a contenttype approval flow to the blog post, then for new nodes i can correctly decline a new publish. If i choose i node with no content type workflow assigned the bug persists.

So yes in short the bug is only related to the new node workflow with no other workflow assigned

@nathanwoulfe
Copy link

Heya @Fjellvang, this one is fixed and building for release now. Will be on Nuget shortly 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants