"Choose type of content" dialog always opens on top of the edit page

[met67]

I have a document type with several properties, the last being a Nested Content data type with multiple sub types.
In the editing a node I have to scroll down the page to reach the (+) icon and add some content to my NC propery, but the dialog opens at the very top of the page and I have to scroll up to see it and chose the content type.
At first I even thought that NC was not working, since clicking on the (+) icon didn't seem to do nothing!

[leekelleher]

@met67 Thanks for reporting... this has been fixed (in PR #123) for the next release, (we haven't set a release date yet).

[leekelleher]

@met67 If you need the fix now, then the latest package build is available on NuGet/MyGet:
https://www.myget.org/gallery/umbraco-packages

If you aren't using NuGet, then the Umbraco package zip can be downloaded from the latest AppVeyor build:
https://ci.appveyor.com/project/UMCO/umbraco-nested-content/build/artifacts

[met67]

Thanks!

[zpbd]

@leekelleher unfortunately I don't think this problem has gone away.

I've tried out your refactor of SayTen's PR, and for me this causes the dialog window to appear off the bottom of the tab, pushing the pane down. The user then needs to try to scroll down the page, but loses focus on the dialog whilst doing so. I've attached two screenshots to demonstrate.

For me, the original PR by SayTen is preferable and this is what I am using for now - the dialog is always fixed in the middle of the browser window. It looks odd because obviously it appears "over to the left" of the tab that you are editing, but at least it will always be visible.

.usky-grid.nested-content__node-type-picker .cell-tools-menu {
    position: fixed;
    left: 50%;
    top: 50%;
    transform: translate(-50%, -50%);
}

I think this needs resolving quickly in a release because a lot of people might be trying out Nested Content and just thinking it doesn't work if they add an NC property at the bottom of a long set of fields. Unfortunately I can't think of a satisfactory CSS-only solution. It might be simpler all around if the dialog appears instead as a pane that comes out from the right, this would also keep it consistent with the rest of the backoffice. Just a thought.

[leekelleher]

@zpbd Thanks for your comments, (I'm catching up after CG17). I've opened a new issue for this, so I will remember to review it, #132.

My issue with the modal being positioned in the middle/centre, is that it looked far too offset when using NC inside a side-panel, (such as DTGE). I wanted to keep it relative to the NC itself. I'm totally open to any improvements on this.