Skip to content
This repository has been archived by the owner on Jun 18, 2018. It is now read-only.

Unique Id for DetachedPublishedContent #7

Closed
Hendy opened this issue Mar 25, 2015 · 7 comments
Closed

Unique Id for DetachedPublishedContent #7

Hendy opened this issue Mar 25, 2015 · 7 comments

Comments

@Hendy
Copy link

Hendy commented Mar 25, 2015

Being able to identify the host (top / real) IPublishedContent and the index (which could be a tree!) would be really helpful

@mattbrailsford
Copy link
Collaborator

We should be able to do this by populating the nodes Parent / ParentId fields, and the SortOrder property. These are currently set to default values.

Would that suffice?

@Hendy
Copy link
Author

Hendy commented Mar 25, 2015

that'd be ideal for my circumstances 👍 but if someone were to use a NC within an NC then the SortOrder int wouldn't be able to represent it's true index - guess that's a real edge case tho

@mattbrailsford
Copy link
Collaborator

that's more an issue of Level, which we should still be able to handle by settings the Level field based on it's parent's value (+1). It wouldn't be a true level in sense of true nodes, but it should suffice in being able to see it's location, relative to it's parent.

Funny this should come up here, as the same discussion is happening on the DTGE issue tracker :)

@Hendy
Copy link
Author

Hendy commented Mar 25, 2015

ooh, yes, re-purpose Level to indicate the current level in Umbraco + levels of NC inception (also if DetachedPublishedContent wasn't internal, it'd be easy to test if an obj was of this specific type)

@Hendy
Copy link
Author

Hendy commented Mar 25, 2015

would you like a PR for this ?

@mattbrailsford
Copy link
Collaborator

It you fancy giving it a go, by all means :)

@leekelleher
Copy link
Collaborator

Closing this issue, discussion an continue on PR #8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants