Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty fields break JS #48

Closed
kjac opened this issue May 11, 2016 · 2 comments
Closed

Empty fields break JS #48

kjac opened this issue May 11, 2016 · 2 comments

Comments

@kjac
Copy link

kjac commented May 11, 2016

If I have a simple text field in multiple languages, and I empty the value of the text field in all languages, the Vorto JS breaks when publishing twice in a row.

Steps:

  • Open the JS console :)
  • In a Vorto datatype wrapping a simple text field, clean out all values in all languages and hit save and publish.
  • Hit save and publish again.
  • The console logs JS errors.

I think it's the assignment of undefined that causes the issue. If you replace undefined with {}, it seems to work just fine.

@dawoe
Copy link

dawoe commented Aug 23, 2016

I created a PR in this issue that fixes it for me #58

@mattbrailsford
Copy link
Collaborator

Should be fixed in 97d9020 / 075b9cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants