Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api responses should return ints where appropriate #215

Open
tybug opened this issue May 2, 2021 · 0 comments
Open

api responses should return ints where appropriate #215

tybug opened this issue May 2, 2021 · 0 comments

Comments

@tybug
Copy link
Contributor

tybug commented May 2, 2021

eg https://api.umd.io/v1/courses/CCJS225/sections/0101 returns:

[
   {
      "course":"CCJS225",
      "section_id":"CCJS225-0101",
      "semester":"202108",
      "number":"0101",
      "seats":"6",
      "meetings":[
         {
            "days":"TuTh",
            "room":"1120",
            "building":"SQH",
            "classtype":"",
            "start_time":"9:30am",
            "end_time":"10:45am"
         },
         {
            "days":"TuTh",
            "room":"1120",
            "building":"SQH",
            "classtype":"",
            "start_time":"9:30am",
            "end_time":"10:45am"
         }
      ],
      "open_seats":"0",
      "waitlist":"07",
      "instructors":[
         "Jessica Morabito"
      ]
   }
]

all of seats, open_ seats, and waitlist should be ints instead. This would technically be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant