Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSDK core functions + subscribers + basic flight control #3

Merged
merged 34 commits into from
Apr 6, 2023

Conversation

biancabnd
Copy link
Contributor

@biancabnd biancabnd commented Mar 28, 2023


Basic Info

Info Please fill out this column
Ticket(s) this addresses (Closes #IssueNumber)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on DJI M300 HITL

Description of contribution in a few bullet points

  • Implemented core functions to create and init a DJI PSDK application
  • Implemented the most important topic subscribers and brought them to ROS
  • Implemented the most important flight control services (e.g. land, takeoff, control position, control velocity)

Description of documentation updates required from your changes


  • Add documentation in Confluence page

Future work that may be required in bullet points

  • Add the remaining topic subscribers from DJI
  • Add more checks through the entire pipeline to make sure that there is no safety concern/ bug within the PSDK library itself
  • Test and spot weak points that can be improved

Review Check

  • There are no conflicts with target branch.

  • Description is intelligible and well written.

  • Passes the CI tests.

  • README.md is updated.

@biancabnd biancabnd self-assigned this Mar 28, 2023
@biancabnd biancabnd changed the base branch from dev to main March 28, 2023 11:46
@biancabnd biancabnd requested a review from a team March 30, 2023 10:43
Copy link
Contributor

@vicmassy vicmassy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stunning work @biancabnd ! Really impressive, huge amount of work put here. Overall the code looks clean, readable and well structured. I added few comments, mainly to trigger some discussions.

Congrats on this 🚀 ⭐

Being the richest man in the cemetery doesn't matter to me. Going to bed at night saying we've done something wonderful, that's what matters to me. - Steve Jobs

umd_psdk_interfaces/srv/GetObstacleAvoidance.srv Outdated Show resolved Hide resolved
umd_psdk_interfaces/srv/SetObstacleAvoidance.srv Outdated Show resolved Hide resolved
umd_psdk_wrapper/include/umd_psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/workflows/jira_ticket_from_issue.yml Outdated Show resolved Hide resolved
umd_psdk_wrapper/include/umd_psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
umd_psdk_wrapper/include/umd_psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
umd_psdk_wrapper/include/umd_psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
umd_psdk_wrapper/src/main.cpp Outdated Show resolved Hide resolved
@vicmassy vicmassy merged commit c73540d into main Apr 6, 2023
4 checks passed
@vicmassy vicmassy deleted the feat/psdk-core-UP-2096 branch April 6, 2023 13:09
@biancabnd biancabnd restored the feat/psdk-core-UP-2096 branch August 7, 2023 15:30
@biancabnd biancabnd deleted the feat/psdk-core-UP-2096 branch August 17, 2023 13:15
@biancabnd biancabnd restored the feat/psdk-core-UP-2096 branch August 21, 2023 08:31
biancabnd pushed a commit that referenced this pull request Sep 7, 2023
PSDK core functions + subscribers + basic flight control
@biancabnd biancabnd deleted the feat/psdk-core-UP-2096 branch September 7, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants