Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional topics #33

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Additional topics #33

merged 3 commits into from
Jan 3, 2024

Conversation

biancabnd
Copy link
Contributor

@biancabnd biancabnd commented Dec 21, 2023 •
edited
Loading

Basic Info

Info Please fill out this column
Ticket(s) this addresses (Closes #IssueNumber)
Primary OS tested on (Ubuntu, MacOS, Windows)
Drone platform tested on DJI M300 RTK

Description of contribution in a few bullet points

  • Added obstacle avoidance topic
  • Added altitude related topics (altitude sea level, altitude barometric and altitude of home point)
  • Added a retry strategy to the initialization function which sometimes returns a timeout error

Motivation and Context

How Has This Been Tested?

  • Tested with DJI M300 drone

Description of documentation updates required from your changes

  • Documentation has been updated accordingly

Future work that may be required in bullet points

Screenshots (if appropriate):

@biancabnd
Add altitude topics
ecf7dd8 
Add max retry nr
@biancabnd biancabnd marked this pull request as ready for review December 22, 2023 08:51
@biancabnd biancabnd requested a review from a team as a code owner December 22, 2023 08:51
@biancabnd biancabnd self-assigned this Dec 22, 2023
@biancabnd biancabnd added the enhancement New feature or request label Dec 22, 2023
amoramar
amoramar reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@amoramar amoramar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see more capabilities added to the PSDK wrapper! 🦾 🔥
I addressed very, very minor details about the comments on the Doxygen documentation for the newly added callback methods. I can push those changes if you are okay with that.

P.S. I have not had the chance to test this in HITL, I can do that as soon as I get access to the hardware.

psdk_wrapper/include/psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
psdk_wrapper/include/psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
psdk_wrapper/include/psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
psdk_wrapper/include/psdk_wrapper/psdk_wrapper.hpp Outdated Show resolved Hide resolved
@biancabnd
Copy link
Contributor Author

Great to see more capabilities added to the PSDK wrapper! 🦾 🔥 I addressed very, very minor details about the comments on the Doxygen documentation for the newly added callback methods. I can push those changes if you are okay with that.

P.S. I have not had the chance to test this in HITL, I can do that as soon as I get access to the hardware.

Thanks for the review @amoramar ! And sure, you can push the changes! Many thanks

@sergigraum sergigraum merged commit df932a6 into main Jan 3, 2024
2 checks passed
@sergigraum sergigraum deleted the feat/add-data-topics branch January 3, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoramar amoramar amoramar approved these changes

Assignees

@biancabnd biancabnd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@biancabnd @amoramar @sergigraum