Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/upgrade to psdk v3.8 #34

Merged
merged 23 commits into from
Feb 14, 2024
Merged

Feat/upgrade to psdk v3.8 #34

merged 23 commits into from
Feb 14, 2024

Conversation

biancabnd
Copy link
Contributor

@biancabnd biancabnd commented Dec 22, 2023 •
edited

Basic Info

Info Please fill out this column
Ticket(s) this addresses (Closes #IssueNumber)
Primary OS tested on (Ubuntu, MacOS, Windows)
Drone platform tested on DJI M300 RTK

Description of contribution in a few bullet points

  • Updated the psdk_ros2 wrapper to be compatible with the latest PSDK v3.8
  • Changed the parameter setting strategy to make it similar to how the PSDK sample code is ran. Now, the specific HW connection parameters are defined via a json file. The application parameters as well as all the topic frequency settings are still defined via the yaml file and are loaded as ROS2 parameters.
  • Updated documentation

Motivation and Context

  • Compatibility with latest PSDK versions
  • Make it easier for users with different HW connections to set up the ros2 wrapper by using the exact strategy being used when running the PSDK sample code.

How Has This Been Tested?

  • Tested with DJI M300 RTK drone with an OSDK connection to an on-board computer running Ubuntu

Description of documentation updates required from your changes

Future work that may be required in bullet points

Screenshots (if appropriate):

@biancabnd biancabnd marked this pull request as ready for review January 12, 2024 09:07
@biancabnd biancabnd requested a review from a team as a code owner January 12, 2024 09:07
@biancabnd biancabnd mentioned this pull request Jan 19, 2024
Open
vicmassy
vicmassy reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@vicmassy vicmassy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but impressive work! Its time for an upgrade 🚀 🪐

P.D. Reminder to also include the lifecycle updates

.github/workflows/industrial_ci.yaml Outdated Show resolved Hide resolved
psdk_wrapper/src/psdk_wrapper.cpp Outdated Show resolved Hide resolved
psdk_wrapper/src/psdk_wrapper.cpp Outdated Show resolved Hide resolved
psdk_wrapper/src/psdk_wrapper.cpp Show resolved Hide resolved
psdk_wrapper/src/psdk_wrapper.cpp Outdated Show resolved Hide resolved
vicmassy
vicmassy reviewed Feb 13, 2024
View reviewed changes
psdk_wrapper/src/psdk_wrapper.cpp Outdated Show resolved Hide resolved
psdk_wrapper/src/psdk_wrapper.cpp Show resolved Hide resolved
@vicmassy vicmassy self-requested a review February 14, 2024 08:03
vicmassy
vicmassy approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@vicmassy vicmassy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Amazing job 🚀

@vicmassy vicmassy merged commit 620255b into main Feb 14, 2024
1 check passed
@vicmassy vicmassy deleted the feat/upgrade-to-psdk-v3.8 branch February 14, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedanomodolor stevedanomodolor stevedanomodolor left review comments

@vicmassy vicmassy vicmassy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@biancabnd @vicmassy @stevedanomodolor @RPS98