Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Health Monitoring System (HMS) as a module #51

Merged
merged 37 commits into from
Feb 20, 2024

Conversation

amoramar
Copy link
Contributor

@amoramar amoramar commented Feb 6, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu 22.04 (ROS2 Humble)
Drone platform tested on DJI M300 RTK + H20 + Enterprise RC

Description of contribution in a few bullet points

  • Add Health Management System (HMS) module to the psdk_wrapper library
    • Register a callback method to fetch the HMS data published by DJI's PSDK
    • Identify known error codes by parsing them from a JSON file
    • Publish the data through a custom ROS2 topic
  • Define two new message types in psdk_interfaces, HmsInfoMsg and HmsInfoTable

Motivation and Context

  • The HMS provides information about the system status that is otherwise not known to the robotics stack.
    • E.g., some of the error codes have the associated consideration of Unable to take off, which is a very important piece of information for the end user.

How Has This Been Tested?

  • Hardware-in-the-loop testing with a DJI M300 RTK drone and an H20 payload.

Description of documentation updates required from your changes

  • A new ROS2 topic psdk_ros2/hms_info_table encapsulates all the information received from the PSDK
  • The actively supported list of known error codes can be found in the PSDK library, in the samples folder for the hms module
    • The CMakeLists.txt in this repository will install the contents of the aforementioned folder locally, thus it will keep track of upstream changes

Future work that may be required in bullet points

Screenshots (if appropriate):

@amoramar amoramar changed the base branch from feat/upgrade-to-psdk-v3.8 to main February 6, 2024 14:36
@amoramar amoramar changed the base branch from main to feat/upgrade-to-psdk-v3.8 February 9, 2024 08:11
Base automatically changed from feat/upgrade-to-psdk-v3.8 to main February 14, 2024 08:06
@amoramar amoramar marked this pull request as ready for review February 19, 2024 10:45
@amoramar amoramar requested a review from a team as a code owner February 19, 2024 10:45
Copy link
Contributor

@vicmassy vicmassy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice job 🚀 🌟

I added few minor comments, and also double check the documentation if you have to add any new topic/module

docs/documentation/GettingStarted.md Show resolved Hide resolved
psdk_interfaces/CMakeLists.txt Outdated Show resolved Hide resolved
psdk_interfaces/msg/HmsInfoMsg.msg Outdated Show resolved Hide resolved
psdk_interfaces/msg/HmsInfoTable.msg Outdated Show resolved Hide resolved
psdk_wrapper/cfg/psdk_params.yaml Show resolved Hide resolved
psdk_wrapper/include/psdk_wrapper/json_utils.hpp Outdated Show resolved Hide resolved
psdk_wrapper/include/psdk_wrapper/psdk_wrapper_utils.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @amoramar ! 🎊 I left you a few comments, but nothing major.
Let me know what you think!

psdk_wrapper/cfg/psdk_params.yaml Outdated Show resolved Hide resolved
psdk_wrapper/include/psdk_wrapper/modules/hms_utils.hpp Outdated Show resolved Hide resolved
psdk_wrapper/src/psdk_wrapper.cpp Outdated Show resolved Hide resolved
psdk_wrapper/src/modules/hms_utils.cpp Outdated Show resolved Hide resolved
docs/documentation/Introduction.md Show resolved Hide resolved
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍 🎊 🥇

@vicmassy vicmassy merged commit e09e7b3 into main Feb 20, 2024
1 check passed
@vicmassy vicmassy deleted the feat/hms-support branch February 20, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants