Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend single battery info #59

Merged
merged 2 commits into from Feb 20, 2024
Merged

extend single battery info #59

merged 2 commits into from Feb 20, 2024

Conversation

stevedanomodolor
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses (Closes #IssueNumber)
Primary OS tested on (Ubuntu, MacOS, Windows)
Drone platform tested on

Description of contribution in a few bullet points

  • extends the single battery info to include capacity percentage

Motivation and Context

How Has This Been Tested?

Description of documentation updates required from your changes

Future work that may be required in bullet points

Screenshots (if appropriate):

@stevedanomodolor stevedanomodolor marked this pull request as ready for review February 19, 2024 13:59
@stevedanomodolor stevedanomodolor requested a review from a team as a code owner February 19, 2024 13:59
biancabnd
biancabnd previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Just a small renaming comment.

psdk_interfaces/msg/SingleBatteryInfo.msg Outdated Show resolved Hide resolved
psdk_wrapper/src/modules/telemetry.cpp Outdated Show resolved Hide resolved
psdk_wrapper/src/modules/telemetry.cpp Outdated Show resolved Hide resolved
@biancabnd biancabnd merged commit 8c7f5ff into main Feb 20, 2024
1 check passed
@biancabnd biancabnd deleted the extend_single_battery_info branch February 20, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biancabnd biancabnd biancabnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevedanomodolor @biancabnd