Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to psdk 3.8.1 #76

Merged
merged 10 commits into from
May 8, 2024
Merged

upgrade to psdk 3.8.1 #76

merged 10 commits into from
May 8, 2024

Conversation

DominikWawak
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (Closes #IssueNumber)
Primary OS tested on (Ubuntu, MacOS, Windows)
Drone platform tested on

Description of contribution in a few bullet points

Motivation and Context

How Has This Been Tested?

Description of documentation updates required from your changes


Future work that may be required in bullet points

Screenshots (if appropriate):

@biancabnd biancabnd marked this pull request as ready for review May 6, 2024 15:03
@biancabnd biancabnd requested a review from a team as a code owner May 6, 2024 15:03
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @DominikWawak! Just some minor comments and we are good to go. 🎊

psdk_wrapper/src/modules/camera.cpp Outdated Show resolved Hide resolved
psdk_interfaces/CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@biancabnd biancabnd merged commit 5a4886a into main May 8, 2024
5 checks passed
@biancabnd biancabnd deleted the feat/psdk-3.8.1 branch May 8, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants