Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Client #57

Open
umgefahren opened this issue Apr 8, 2022 · 4 comments · May be fixed by #59
Open

New Client #57

umgefahren opened this issue Apr 8, 2022 · 4 comments · May be fixed by #59
Assignees
Labels
Client Regarding the benchmark client enhancement New feature or request

Comments

@umgefahren
Copy link
Owner

There will be a new client, since the old one is very performant but very useless. Please tell me, what you want to see in the new client.

@umgefahren umgefahren added the Client Regarding the benchmark client label Apr 8, 2022
@umgefahren umgefahren added the enhancement New feature or request label Apr 8, 2022
@umgefahren umgefahren pinned this issue Apr 8, 2022
@vypxl
Copy link
Collaborator

vypxl commented Apr 8, 2022

Cool fancy output

@TecTrixer
Copy link
Collaborator

TecTrixer commented Apr 8, 2022

Client Spec

Interface

There should be a cli interface build with clap and as well the possibility to send commands. The latter should not be done with a dialogue selector, but rather in an ncat style. This way you can also test your implementation for syntax errors and invalid commands. It should also be easier.

Options

  • count: specify the number of test cases to generate and benchmark a client with (conflicts with time)
  • time: specify the time to run your benchmark (conflicts with count)
  • port: optionally give a specific port
  • server: optionally specify the server, for example localhost or 0.0.0.0

Subcommands

  • interactive (ncat style)
  • benchmark (should automatically regenerate new test cases)

@umgefahren
Copy link
Owner Author

I started working on the client. In order to be more flexible with benchmarking and testing plans I'm working on an option to provide a config file.
What do you think about something like this:

general:
  totalduration: 10.0
  serverhostname: localhost
  serverport: 8080
  commandsperconn: 5
basic:
  key:
    minlen: 10
    maxlen: 1000
    alphanumeric: false
  value:
    minlen: 10
    maxlen: 1000
    alphanumeric: false
  cycleduration: -1.0
  cyclepattern: SET-GET-GET-GET-DEL

@umgefahren umgefahren linked a pull request Apr 9, 2022 that will close this issue
@vypxl
Copy link
Collaborator

vypxl commented Apr 10, 2022

Looks nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Regarding the benchmark client enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants