Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets support #27

Closed
ericduvic opened this issue Dec 8, 2020 · 3 comments
Closed

Secrets support #27

ericduvic opened this issue Dec 8, 2020 · 3 comments

Comments

@ericduvic
Copy link
Contributor

What is the current behavior?
There's no variable for declaring secrets in the task definition

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
I guess this is more of a feature request?

What is the expected behavior?
A secrets variable is available that replicates functionality in the task definition parameter as provided by https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html

Software versions?
Latest versions of terraform and umotif-public/terraform-aws-ecs-fargate
@ericduvic ericduvic mentioned this issue Dec 8, 2020
Merged
@ericduvic
Copy link
Contributor Author

I've proposed a fix in PR #28

@ericduvic
Copy link
Contributor Author

Merged in, I guess the only thing left is to update the docs

@marcincuber
Copy link
Contributor

marcincuber commented Dec 9, 2020 •
edited

@ericduvic docs updated and everything is released as part of 5.1.0.

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericduvic @marcincuber