Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML structure is probably wrong (and weird at least) #5

Open
boekabart opened this issue Jul 3, 2020 · 1 comment
Open

XML structure is probably wrong (and weird at least) #5

boekabart opened this issue Jul 3, 2020 · 1 comment

Comments

@boekabart
Copy link

First off: Thank you for this and the country list as well!

I ended up using the json version because the xml of both projects is wrong or at least weird. Take a look:

<?xml version="1.0" encoding="utf-8"?>
<values>
    <item>
        <id>af</id>
        <![CDATA[Afrikaans]]>
        <value />
    </item>
    <item>
        <id>af_NA</id>
        <![CDATA[Afrikaans (Namibia)]]>
        <value />
    </item>

I presume that the intent was to have the value inside the <value> tag like so:

<?xml version="1.0" encoding="utf-8"?>
<values>
    <item>
        <id>af</id>
        <value><![CDATA[Afrikaans]]></value>
    </item>

The current format is probably technically correct XML, but very hard to parse by most libraries because the <item> element mixes both child elements and text; which is unusual.

@umpirsky
Copy link
Owner

umpirsky commented Jul 3, 2020

Ouch, that does look wrong, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants