Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter is mistaken in counting comments #261

Closed
ob-tk opened this issue Jan 25, 2019 · 4 comments
Closed

Counter is mistaken in counting comments #261

ob-tk opened this issue Jan 25, 2019 · 4 comments
Assignees
@umputun
Labels
backend bug
Milestone
v1.3

Comments

@ob-tk
Copy link

ob-tk commented Jan 25, 2019

After adding a single comment and deleting it, the counter returns 1 for this page.
@umputun
Copy link
Owner

umputun commented Jan 25, 2019

@Reeywhaar could you add both counter and last comment widget to a dev page we have? It will help to check issues like this right away

@ob-tk
Copy link
Author

ob-tk commented Jan 25, 2019

UPD: Error occurs when user deletes own comment, not admin

@Reeywhaar Reeywhaar mentioned this issue Jan 25, 2019
Merged
umputun added a commit that referenced this issue Jan 25, 2019
@umputun
add unit test for counters #261
8f0b6a6
umputun added a commit that referenced this issue Jan 25, 2019
@umputun
fix lack of counter invalidation from the cache #261
1cc09a3
@umputun umputun self-assigned this Jan 25, 2019
@umputun
Copy link
Owner

umputun commented Jan 26, 2019

@OnlineBiblioTK - thx for the report, it helped to fix an interesting cache related issue. Should be fine now, I'll consider bugfix release as soon as done with #262

@Reeywhaar - thx for the help.

@ob-tk
Copy link
Author

ob-tk commented Jan 26, 2019

Thank you for your work

@umputun umputun closed this as completed Jan 26, 2019
@daniloarcidiacono daniloarcidiacono mentioned this issue Sep 11, 2022
Closed
@paskal paskal modified the milestones: v1.11.3, v1.3 Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umputun umputun

Labels
backend bug
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
3 participants
@umputun @paskal @ob-tk