Add "simple view" mode #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed test if one of the flapping ones (#380) which I haven't yet tackled. A restart of the tests should show no errors on the backend (due to lack of changes). |
|
I've restarted test, it shows failed frontend checks https://github.com/umputun/remark/commit/280c0c0971abfa5a2c0477871f9822c83cdb85c2/checks?check_suite_id=377582109#step:9:297 |
|
@umputun yeah, my mistake. |
|
seems to hide all it supposed to hide, however, spacing on top looks strange
|
umputun
reviewed
Dec 30, 2019
added 4 commits
December 31, 2019 01:28
It just hide elements from view when SIMPLE_VIEW recived from server
* remove SIMPLE_VIEW from default settings for forntend dev * add private compose to gitignore
akellbl4
force-pushed
the
feature/474_simple-view
branch
from
1928add
to
f6bb05e
Compare
|
styles ok, however, you missed reply box:
|
* `simpleView` changed to required param
|
looks like reply box has the same style issue:
|
|
I think you've missed edit box
|
|
@umputun I hope it last place :) |
|
LTGM, thx |
akellbl4
pushed a commit
to akellbl4/remark42
that referenced
this pull request
Jan 4, 2020
* Add "simple view" mode support It just hide elements from view when SIMPLE_VIEW recived from server * Fix typing and add ts check before push * proper input styling * Changes for frontend dev compose * remove SIMPLE_VIEW from default settings for forntend dev * add private compose to gitignore * Added simpleView mode for replay and edit modes. * `simpleView` changed to required param * FIx border-width in reply form * Fix border-width in editing mode
This was referenced Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just hide elements from view when
simple_viewreceived from server.Resolving #474