Fix flapping TestRest_ tests #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix false positive
akellbl4
pushed a commit
to akellbl4/remark42
that referenced
this pull request
Jan 3, 2020
* replace single-member wait groups with channels * increase TestRest_LastCommentsStreamSince comment write delay * increase timeout for TestRest_InfoStreamCancel * increase TestServerApp timeout * adjust waiting time in TestRest_LastCommentsStreamSince in attempt to fix false positive * adjust comments waiting location in multiple TestRest_ tests
akellbl4
pushed a commit
to akellbl4/remark42
that referenced
this pull request
Jan 3, 2020
* replace single-member wait groups with channels * increase TestRest_LastCommentsStreamSince comment write delay * increase timeout for TestRest_InfoStreamCancel * increase TestServerApp timeout * adjust waiting time in TestRest_LastCommentsStreamSince in attempt to fix false positive * adjust comments waiting location in multiple TestRest_ tests
akellbl4
pushed a commit
to akellbl4/remark42
that referenced
this pull request
Jan 3, 2020
* replace single-member wait groups with channels * increase TestRest_LastCommentsStreamSince comment write delay * increase timeout for TestRest_InfoStreamCancel * increase TestServerApp timeout * adjust waiting time in TestRest_LastCommentsStreamSince in attempt to fix false positive * adjust comments waiting location in multiple TestRest_ tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subj,
<-doneposition was wrong in multiple locations inrest_public_test.go. 6 test runs of GitHub Actions I've conducted haven't shown any problems after this PR.