Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in comment.tsx component #522

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Fix warnings in comment.tsx component #522

merged 1 commit into from
Jan 5, 2020

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jan 3, 2020

It happened because this.setState was used in constructor

Warnings

2020-01-03 17 22 48

@akellbl4 akellbl4 changed the title Fix warnings in comment.tsx component Fix warnings in comment.tsx component Jan 3, 2020
@akellbl4 akellbl4 requested a review from umputun January 5, 2020 18:45
@umputun umputun merged commit 2efab67 into umputun:master Jan 5, 2020
@akellbl4 akellbl4 deleted the fix/remove-setstate-from-constructor branch June 13, 2021 08:32
@paskal paskal added this to the v1.5 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

@Mavrin Mavrin Mavrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akellbl4 @umputun @Mavrin @paskal