Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user info redesign/redevelop and add dark theme #1018

Merged
merged 14 commits into from Aug 8, 2021
Merged

user info redesign/redevelop and add dark theme #1018

merged 14 commits into from Aug 8, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 19, 2021

Resolves #920

  • remove dropdown on user name in login block
  • open user info by click on user name
  • replace Logout with icon
  • remove label in login block
  • move Request my data removal to user info
  • add additional logout button in user info
  • implement empty state
  • write tests
  • add Hide user comments to user info (changing logic is needed for using in another place)

The size of the styles increased because default styles were moved from HTML to CSS.

@akellbl4 akellbl4 requested a review from umputun as a code owner May 19, 2021 17:55
@akellbl4 akellbl4 changed the base branch from master to postmessage-to-child May 19, 2021 17:57
@akellbl4 akellbl4 marked this pull request as draft May 19, 2021 17:57
@github-actions
Copy link

github-actions bot commented May 19, 2021

size-limit report 📦

Path Size
public/embed.mjs 1.9 KB (-14.91% 🔽)
public/remark.mjs 66.19 KB (+1.35% 🔺)
public/remark.css 9.42 KB (+8.51% 🔺)
public/last-comments.mjs 30.14 KB (+0.2% 🔺)
public/last-comments.css 5.06 KB (+2.05% 🔺)
public/deleteme.mjs 9.79 KB (0%)
public/counter.mjs 601 B (0%)

@akellbl4 akellbl4 force-pushed the user-info branch 4 times, most recently from be31ebb to d3b9c64 Compare May 22, 2021 15:44
@akellbl4 akellbl4 force-pushed the user-info branch 6 times, most recently from 895b8dd to 92bb12e Compare May 23, 2021 11:55
@akellbl4 akellbl4 added this to the v1.9 milestone May 25, 2021
Base automatically changed from postmessage-to-child to master June 3, 2021 05:56
@akellbl4 akellbl4 force-pushed the user-info branch 4 times, most recently from 990c355 to 8d69dff Compare August 5, 2021 12:08
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1018 (ca6bad4) into master (36840ed) will increase coverage by 3.21%.
The diff coverage is 52.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   44.16%   47.38%   +3.21%     
==========================================
  Files         126      134       +8     
  Lines        2907     2942      +35     
  Branches      654      658       +4     
==========================================
+ Hits         1284     1394     +110     
+ Misses       1610     1538      -72     
+ Partials       13       10       -3     
Impacted Files Coverage Δ
frontend/app/common/types.ts 100.00% <ø> (ø)
frontend/app/components/auth-panel/index.ts 0.00% <ø> (ø)
frontend/app/components/auth/auth.messsages.ts 100.00% <ø> (ø)
...end/app/components/list-comments/list-comments.tsx 0.00% <ø> (ø)
frontend/app/components/profile/index.ts 0.00% <0.00%> (ø)
frontend/app/components/root/root.tsx 0.00% <0.00%> (ø)
frontend/app/components/verified.tsx 0.00% <0.00%> (ø)
frontend/app/embed.ts 0.00% <0.00%> (ø)
frontend/app/profile.ts 0.00% <0.00%> (ø)
frontend/app/remark.tsx 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e3ea8...ca6bad4. Read the comment docs.

@akellbl4 akellbl4 requested a review from Mavrin August 5, 2021 13:17
@akellbl4 akellbl4 marked this pull request as ready for review August 5, 2021 13:17
@paskal
Copy link
Sponsor Collaborator

paskal commented Aug 5, 2021

make rundev under M1:

<there was long error>
------
executor failed running [/bin/sh -c cd /srv/frontend &&     if [ -z "$SKIP_FRONTEND_TEST" ] ; then npx run-p lint test check;     else echo "skip frontend tests and lint" ; npm run build ; fi &&     rm -rf ./node_modules]: exit code: 1
ERROR: Service 'remark42' failed to build : Build failed
make: *** [rundev] Error 1

@akellbl4
Copy link
Collaborator Author

akellbl4 commented Aug 6, 2021

@paskal it was typo, just fixed

@akellbl4 akellbl4 requested a review from paskal August 6, 2021 06:59
paskal
paskal previously approved these changes Aug 6, 2021
Copy link
Sponsor Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM, it works and looks neat.

@akellbl4
Copy link
Collaborator Author

akellbl4 commented Aug 8, 2021

@paskal thank you for the review. I'm not sure if you checked the right part of the ui. I've added screenshots. Sorry I had to do it in the first place.

User's profile:
CleanShot 2021-08-08 at 10 42 00@2x
CleanShot 2021-08-08 at 10 42 10@2x

Own profile:
CleanShot 2021-08-08 at 10 46 22@2x
CleanShot 2021-08-08 at 10 46 36@2x

Empty state:
CleanShot 2021-08-08 at 10 56 54@2x
CleanShot 2021-08-08 at 10 56 48@2x

paskal
paskal previously approved these changes Aug 8, 2021
Mavrin
Mavrin previously approved these changes Aug 8, 2021
Copy link
Collaborator

@Mavrin Mavrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@umputun umputun dismissed stale reviews from Mavrin and paskal via ca6bad4 August 8, 2021 18:34
@umputun umputun merged commit cac1eb2 into master Aug 8, 2021
@umputun umputun deleted the user-info branch August 8, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile info remains light when using dark theme
4 participants