Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<nil> as name when Name not set in github profile #6

Closed
23ua opened this issue May 12, 2018 · 2 comments
Closed

<nil> as name when Name not set in github profile #6

23ua opened this issue May 12, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@23ua
Copy link

23ua commented May 12, 2018

Maybe use a username if name is not set?
screen shot 2018-05-12 at 20 59 39
screen shot 2018-05-12 at 21 00 01

@umputun umputun self-assigned this May 12, 2018
@umputun umputun added the bug label May 12, 2018
@umputun
Copy link
Owner

umputun commented May 12, 2018

In this case, github api returns string <nil> as user. I have added the fix to use login name for such cases. Pls note - to see the fix you need to re-login.

@23ua
Copy link
Author

23ua commented May 12, 2018

Thanks, the fix worked, although the name in the old comment didn't change.
I assume this is ok since changing the name in github doesn't affect old comments in other cases as well.

@23ua 23ua closed this as completed May 12, 2018
@umputun umputun added this to the v1.0.0 milestone May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants