Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to respository #1

Closed
wants to merge 1 commit into from

Conversation

FrTerstappen
Copy link

The link to the github repository was missing the final 's'. This makes the link on crates.io not work. I think this requires a new release to crates.io

The link to the github repository was missing the final 's'. This makes the link on crates.io not work.
I think this requires a new release to crates.io
@umut-sahin
Copy link
Owner

Hi @FrTerstappen, thanks for noticing!

Could you update your commit message to the following please?

chore: fix repository url

Once it's done, I'll merge the PR, add you as an author, update the version, and make the release.

Btw, I need your email to add you to as an author in Cargo.toml, could you send it?

Thanks!

@FrTerstappen
Copy link
Author

I think i can not change the commit message form the website and I am only back at a computer in a few days.
Alternatively you can just handle this like a open issue, fix the error yourself and close this pull request. Also no need to add me to the authors for such a minor edit.

@umut-sahin
Copy link
Owner

I'll make the changes myself then. It would have taken me a very long time to realize this, so thanks a lot! If you change your mind, let me know and I'll add you as an author anytime :)

@umut-sahin
Copy link
Owner

(closed by 9defd55)

@umut-sahin umut-sahin closed this Aug 12, 2023
@FrTerstappen FrTerstappen deleted the main-1 branch September 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants