[CALR-1] SUR - Vessel info fail for some vessels

[eblondel]

Issue migrated from JIRA: https://sdlc.review.fao.org/jira/browse/CALR-1
Creator/Reporter: Yann Laurent @yannlaurent
Assignee: Alexandre Bennici @abennici
Priority: Medium
Status: Done
Date of creation: 2021-10-18T13:36:44.000+0000

In the the Shiny app connected to the SUR database:

In the vessel dashboard / Vessels Register, search for the industrial vessel ARAVIS (in the search area)

you get one record. Click on "details" at the end of the line: the R Shiny app crashes.

I got the following error in the R Console:

Selecting vessel 'SA00173'
Warning: Error in round: argument non numérique pour une fonction mathématique
44: [./modules/core/vessel_info_server.R#53]
1: runApp

 

[eblondel]

Author: Emmanuel Blondel @eblondel
Date of creation: 2021-10-18T13:48:03.062+0000
Last update: 2021-10-18T13:48:03.062+0000

Thanks [~yann.laurent], i've reproduced the issue.  [~alexandre.bennici@fao.org] can look at it in R, i'd like to make sure it's not a problem of data integrity, but first check through fishing_activities.sql query i don't see issues

From R, I see: 

``

Warning: Error in round: non-numeric argument to mathematical function
44: [./modules/core/vessel_info_server.R#53|#53]

``

The round issue is at time at sea that is computing as diff between departure / return time. Possibly an issue with the units handled during time computation.

 

[eblondel]

Author: Alexandre Bennici @abennici
Date of creation: 2021-10-18T14:30:47.288+0000
Last update: 2021-10-18T14:30:47.288+0000

I add a controlling case to manage time at sea already expressed in "days". That should be fix the issues. I maked test and that work for this vessel and some others,