Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual rebase and sync upstream #13

Closed
SukkaW opened this issue Jul 30, 2023 · 2 comments
Closed

Manual rebase and sync upstream #13

SukkaW opened this issue Jul 30, 2023 · 2 comments

Comments

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 30, 2023

@JounQin

eslint-plugin-i seems to be up of sync from upstream for months:

image

A manual rebase is required.


The object.groupby package can be replaced with this:

// This is a **non spec compliant** but works in practice replacement of `object.groupby` package.
const groupBy = (array, grouper) => array.reduce((acc, cur) => {
  const key = grouper(cur);
  (acc[key] = acc[key] || []).push(cur);
  return acc;
}, {});

And object.fromentries can be replaced with const { fromEntries } = Object;

@JounQin
Copy link
Member

JounQin commented Jul 30, 2023

Thanks for reminding, I'll do it tomorrow.

@JounQin
Copy link
Member

JounQin commented Jul 31, 2023

v2.28.0-1 released

@JounQin JounQin closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants